[tahoe-dev] how to submit patches

[zooko]

I really like using the mailing list for patches, because the mailing  
list is a public, on-the-record conversation that includes everyone.

What about this:

darcs send -o patch.darcspatch
darcs diff -u -p"${PATCHRE}" > patch.diff.txt

and then send both to the mailing list as attachments?  This is more  
work for the submitter, as they have to attach the files to a message  
and send the message (instead of allowing "darcs send" to send the  
message for them).

The good things about this are (a) hopefully everyone can see the  
patch contents in-line in the mail and (b) you can add a "cover  
letter" -- a message to the mailing list about the patch.

Here, I'll try it:

Here is a patch that copies in a utility file to format timestamps  
that I've been using for many a year, including in Mnet and in Mojo  
Nation.  It is ISO-8601 ish

http://www.cl.cam.ac.uk/~mgk25/iso-time.html

It is in UTC instead of localtime, which turns out to be better in my  
experience because I more often compare timestamps from different  
nodes running in (potentially) different timezones to each other than  
I compare timestamps from a node to timestamps from other sources in  
the same timezone.  Also having everything be in UTC means we don't  
need to spend precious columns on a timezone indicator (or else have  
to figure out the right timezone from other context).

This version comes with microseconds precision, but that is of course  
easily changed.

Brian: Please apply!  :-)

Regards,

Zooko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.darcspatch
Type: application/octet-stream
Size: 31707 bytes
Desc: not available
URL: <http://tahoe-lafs.org/pipermail/tahoe-dev/attachments/20070814/563c9508/attachment.obj>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.diff.txt
URL: <http://tahoe-lafs.org/pipermail/tahoe-dev/attachments/20070814/563c9508/attachment.txt>
-------------- next part --------------