[tahoe-dev] Trivial patch: a couple of working unittests for testutil.

Nathan nejucomo at gmail.com
Fri Sep 7 23:27:20 UTC 2007


This small patch adds some unittests for testutil.PollMixin which was
not previously covered directly by unittests.  diff -u follows:

Fri Sep  7 17:15:41 MDT 2007  nejucomo at gmail.com
  * Add some passing unit tests for testutil.PollMixin.
diff -rN -u old-tahoe/src/allmydata/test/test_util.py
new-tahoe/src/allmydata/test/test_util.py
--- old-tahoe/src/allmydata/test/test_util.py	2007-09-07
17:22:37.000000000 -0600
+++ new-tahoe/src/allmydata/test/test_util.py	2007-09-07
17:22:38.000000000 -0600
@@ -5,7 +5,7 @@
 from twisted.trial import unittest

 from allmydata.util import bencode, idlib, humanreadable, mathutil
-from allmydata.util import assertutil, fileutil
+from allmydata.util import assertutil, fileutil, testutil


 class IDLib(unittest.TestCase):
@@ -368,3 +368,23 @@
         used = fileutil.du(basedir)
         self.failUnlessEqual(10+11+12+13, used)

+class PollMixinTests(unittest.TestCase):
+    def setUp(self):
+        self.pm = testutil.PollMixin()
+
+    def _check(self, d):
+        def fail_unless_arg_is_true(arg):
+            self.failUnless(arg is True, repr(arg))
+        d.addCallback(fail_unless_arg_is_true)
+        return d
+
+    def test_PollMixin_True(self):
+        d = self.pm.poll(check_f=lambda : True,
+                         pollinterval=0.1)
+        return self._check(d)
+
+    def test_PollMixin_False_then_True(self):
+        i = iter([False, True])
+        d = self.pm.poll(check_f=i.next,
+                         pollinterval=0.1)
+        return self._check(d)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PollMixin_unittest.darcspatch
Type: application/octet-stream
Size: 6849 bytes
Desc: not available
URL: <http://tahoe-lafs.org/pipermail/tahoe-dev/attachments/20070907/96228f8c/attachment.obj>


More information about the tahoe-dev mailing list