[tahoe-dev] timestamps (was: collective effort to improve logging)

zooko zooko at zooko.com
Tue Sep 18 18:58:49 UTC 2007


I would be happy with ISO-8601 (with s/T/ /), UTC (with appended "Z"  
to make it clear), and precision anywhere from seconds to  
milliseconds (or even finer, if someone really wants it).

This would look like:

2007-09-17 09:32:01.122Z [Client] z23k6ynh: 'connected to qtjkk6cy'

I'm not entirely sure how I would implement this change though...

Here is the method named "log" in the Node class:

http://allmydata.org/trac/tahoe/browser/src/allmydata/node.py#L166

Using the darcs patch browser ( http://allmydata.org/darcs.cgi/tahoe/? 
c=browse ), I can click on that line to see patch most recently  
changed it:

http://allmydata.org/darcs.cgi/tahoe/src/allmydata/node.py? 
c=annotate&p=20070811215237-8478c-5d84af3046236c8a072f6adb2e18f7a3db56a7 
1b.gz&ch=20061203002718-4233b-27cbc1b70e1240b7c5d9886b4c2e9f5ff9464024.g 
z&o=./allmydata/node.py

This was a patch contributed by Arno ( http://allmydata.org/trac/ 
tahoe/changeset/1192 ).

I don't know the "timeFormat" specification for the timestamp format  
that I want.

However, this only changes log messages which were made by calling  
Node.log() -- not log messages made by twisted.log.  Is that okay  
with us?

Regards,

Zooko




More information about the tahoe-dev mailing list