[tahoe-dev] [tahoe-lafs] #928: start downloading as soon as you know where to get K shares

[tahoe-lafs]

#928: start downloading as soon as you know where to get K shares
-----------------------------------------------+----------------------------
 Reporter:  zooko                              |           Owner:  zooko
     Type:  defect                             |          Status:  new  
 Priority:  major                              |       Milestone:  1.6.0
Component:  code-peerselection                 |         Version:  1.5.0
 Keywords:  download availability performance  |   Launchpad_bug:       
-----------------------------------------------+----------------------------

Comment(by zooko):

 Here is a fix (dontwait7.darcspatch.txt) for the problem in _copy_share(),
 rewrite line-endings to by '\n', and add a comment. (Perhaps you should
 re-record these patches into a single patch that we can then apply to
 close this ticket.)

 Brian: David-Sarah's patch, included in "new-tests-for-928-darcspatch.txt"
 fixes two bugs in my patch and is cleaner without being more invasive.
 Please re-review! (I've already reviewed it and will commit it, but it
 wouldn't hurt for you to review it as well.)

 The two bugs were:

 1.  In my patch I errback()'ed in one place when I should have
 callback()'ed in all three places. (David-Sarah's patch improves this by
 coalescing two of those paths so they result in a single function.)
 2.  In my patch I checked for out-of-servers condition ''inside'' the
 {{{for sharenum, bucket in buckets.iteritems():}}}, so if the final server
 answered the query but said it had zero buckets then that check would be
 wrongly omitted.

-- 
Ticket URL: <http://allmydata.org/trac/tahoe/ticket/928#comment:12>
tahoe-lafs <http://allmydata.org>
secure decentralized file storage grid