[tahoe-dev] github plan?
david-sarah at jacaranda.org
Sat Mar 23 03:05:05 UTC 2013
On 21/03/13 09:42, Randall Mason wrote:
> What is the current preferred structure of development? Should pull
> requests be used at all?
The preferred workflow is:
1. A contributor either makes a pull request or attaches a diff to a ticket
(their choice). They comment on the ticket linking to the request or diff,
and add the 'review-needed' keyword to that ticket.
2. A reviewer reviews the pull request or diff. If it is okay, they change
the keyword to 'reviewed'.
3. In that case, a committer (Zooko, Brian, Kevan or me) -- maybe the same
person as the reviewer -- then accepts the trac ticket.
4. The committer pulls the branch or applies the diff, rebasing and linearizing
it on top of current trunk (maybe with small changes that don't necessitate
5. The committer runs automated tests and smoke tests, then pushes to trunk.
If this is not a fast-forward then the push will fail, in which case
they rebase and push again.
> Can trac interact with a github pull request?
This workflow doesn't cause any problem for trac.
David-Sarah Hopwood ⚥
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 555 bytes
Desc: OpenPGP digital signature
More information about the tahoe-dev